Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

On 24 May 2025, at 7:08 PM, David E. Wheeler <david@justatheory.com> wrote:

On May 23, 2025, at 13:52, Tom Lane <tgl@sss.pgh.pa.us> wrote:

I assume you mean that they’re set at initdb time, so there’s no mutability concern?

Yeah, I think Peter's right and I'm wrong.  Obviously this ties into
our philosophical debate about how immutable is immutable.  But as
long as the functions only depend on locale settings that are fixed
at database creation, I think it's okay to consider them immutable.

If you were, say, depending on LC_NUMERIC, it would clearly be unsafe
to consider that immutable, so I'm not quite sure if this is the end
of the discussion.  But for what's mentioned in the thread title,
I think we only care about LC_CTYPE.

Oh, so maybe all this is moot, and Florents can go ahead and add support for the functions to the non-_tz functions?

I think the patch is still in reasonably good shape and hasn’t changed much since September 24.

So yes, I’d hope there are still some valid points to consider or improve.

Otherwise, I’ll have only myself to blame for not pushing harder before the feature freeze. 😅