Re: Mark function arguments of type "Datum *" as "const Datum *" where possible

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Mark function arguments of type "Datum *" as "const Datum *" where possible
Дата
Msg-id 4061336.1758898813@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Mark function arguments of type "Datum *" as "const Datum *" where possible  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: Mark function arguments of type "Datum *" as "const Datum *" where possible
Список pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> I have mixed feelings about this patch.  I have no concrete objections to
> the technical content, but some questions come to mind.  For example, why
> are we only fixing Datum parameters?

Yeah.  In particular, probably 99% of such Datum arrays also have an
associated array of bool isnull flags.  IMO it makes exactly zero
sense to const-ify the Datums without similar protection for their
isnull flags.

            regards, tom lane



В списке pgsql-hackers по дате отправления: