Re: Non-blocking communication between a frontend and a backend (pqcomm)

Hi,

On Wed, Jul 22, 2009 at 2:20 AM, Robert Haas<robertmhaas@gmail.com> wrote:
> Fujii Masao,
>
> Are you planning to update this patch based on Martin's review?

Sure. Attached is an updated patch.

> On Fri, Jul 17, 2009 at 5:26 PM, Martin Pihlak<martin.pihlak@gmail.com> wrote:
>> Here's my initial review of the non-blocking pqcomm patch. The patch applies
>> cleanly and passes regression. Generally looks nice and clean. Couple of remarks
>> from the department of nitpicking:

Thanks for reviewing the patch!

>> * In secure_poll() the handling of timeouts is different depending whether
>>  poll(), select() or SSL_pending() is used. The latter doesn't use the
>>  timeout value at all, and for select() it is impossible to specify indefinite
>>  timeout.

Fixed. I tweaked the handling of the fifth argument 'timeout' of select(); when
a negative number is specified to a timeout of secure_poll(), NULL is set to
that 'timeout', which can block select() indefinitely.

Since SSL_pending() doesn't wait for data to arrive (i.e., doesn't use timeout),
I didn't change the code related to that function.

>> * occasional "blank" lines consisting of a single tab character -- maybe
>>  a left-over from editor auto-indent. Not sure of how much a problem this
>>  is, given that the blanks will be removed by pg_indent.

Fixed.

>> * Comment on pq_wait() seems to have a typo: "-1 if an error directly."

Fixed.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center