Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (butnot seq_tup_read)

On 2020/02/07 17:28, Kasahara Tatsuhito wrote:
> Hi,
> 
> On Fri, Feb 7, 2020 at 5:02 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> BTW, commit 147e3722f7 causing the issue changed currtid_byreloid()
>> and currtid_byrelname() so that they also call table_beginscan().
>> I'm not sure what those functions are, but probably we should fix them
>> so that table_beginscan_tid() is called instead. Thought?
> +1, sorry, I overlooked it.
> 
> Both functions are used to check whether a valid tid or not with a
> relation name (or oid),
> and both perform a tid scan internally.
> So, these functions should call table_beginscan_tid().
> 
> Perhaps unnecessary, I will attach a patch.

Pushed! Thanks!

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters