Re: gcc3.3 compliance

Dave Page wrote:

>
>
>>-----Original Message-----
>>From: Jean-Michel POURE [mailto:jm.poure@freesurf.fr]
>>Sent: 12 June 2003 16:50
>>To: pgadmin-hackers@postgresql.org
>>Cc: Adam Pendleton
>>Subject: Re: [pgadmin-hackers] gcc3.3 compliance
>>
>>
>>On Thursday 12 June 2003 17:09, you wrote:
>>
>>
>>>Can you CVS update please? I fixed that yesterday (unless someone
>>>un-fixed it again).
>>>
>>>
>>This is an error output from today. It only occurs under SuSE
>>82. Maybe we
>>should wait for Adam patch review and then I will try again
>>to compile under
>>SuSE.
>>
>>
>
>Dunno what it is then. It is *exactly* the error I saw, on exactly the
>same line of the file after Andreas commited a change. I added the cast
>to long and it was fine.
>
>
>
This fix breaks win32 compilation, and I really don't know what kind of
foolishness gcc does here. All GetXXX pairs are defined equally, but
only GetLong will show that problem.
The argument to GetLong is an int, and ColNumber returns int, that
should make a perfect fit. With the fix applied, msdev will complain
"two similar conversions". Maybe it helps if all GetXXX(int) are defined
as GetXXX(const int); please check this.

Regards,
Andreas