Re: Improve TAP tests of pg_upgrade for cross-version tests

On 2022-06-12 Su 10:14, Andrew Dunstan wrote:
> On 2022-06-09 Th 03:49, Michael Paquier wrote:
>> On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote:
>>> On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote:
>>>> (Adding Andrew Dunstan in CC.)
>>>>
>>>> I have been toying with $subject, trying to improve the ways to test
>>>> pg_upgrade across different major versions as perl makes that easier.
>>>> The buildfarm does three things to allow such tests to work (see
>>>> TestUpgradeXversion.pm):
>> Rebased to cope with the recent changes in this area.
>
> I tried in fb16d2c658 to avoid littering the mainline code with
> version-specific tests, and put that in the methods in the subclasses
> that override the mainline functions.
>
> I'll try to rework this along those lines.
>
>

I think I must have been insufficiently caffeinated when I wrote this,
because clearly I was not reading correctly.


I have had another look and the patch looks fine, although I haven't
tested it.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com