Re: [HACKERS] Patch attached...

Hannu Krosing wrote:
> 
> Hi
> 
> I looked at the patch and for me the name of the variable
> to set to get the old behaviour (SET EXAMINE_SUBCLASS TO 'on';)
> seems confusing.
> 
> At first I thought it was a typo to set it to 'ON' for old behaviour,
> my internal logic would set it to 'OFF' to not select subclass by default.

Umm, but that IS how it works...

$ psql
Welcome to psql, the PostgreSQL interactive terminal.

Type:  \copyright for distribution terms      \h for help with SQL commands      \? for help on internal slash commands
    \g or terminate with semicolon to execute query      \q to quit
 
pghack=# select * from a;aa  
-----aaabbb
(2 rows)

pghack=# set examine_subclass to 'off';
SET VARIABLE
pghack=# select * from a;aa  
-----aaa
(1 row)

> I think something like DONT_SELECT_INHERITED or OLD_INHERITED_SELECT_SYNTAX
> would be much clearer in meaning.

I'm happy to hear alternative names, but I don't really want "SELECT" in
the name, because this might  apply to UPDATE eventually too.


> 
> Actually the name is not very important, as most people won't use it anyway ;)
> 
> ----------------
> Hannu

-- 
Chris Bitmead
mailto:chris@bitmead.com