Re: Parsing of pg_hba.conf and authentication inconsistencies

On Mon, Sep 15, 2008 at 10:53 PM, Magnus Hagander <magnus@hagander.net> wrote:
>
> Thanks for the reviews, guys. I've adjusted the patch per your comments
> (I think), and applied it.
>

Cool.  I had a look at the commitdiff and I think you missed one of
the error messages (it's still all on one line).  It's at
src/backend/libpq/hba.c line 841.  I've included a patch to split it
up below.

Cheers,
BJ

--- src/backend/libpq/hba.c
+++ src/backend/libpq/hba.c
@@ -840,9 +840,10 @@ hba_syntax:    if (line_item)        ereport(LOG,
(errcode(ERRCODE_CONFIG_FILE_ERROR),
-                 errmsg("invalid entry in file \"%s\" at line %d, token \"%s\"",
-                        HbaFileName, line_num,
-                        (char *) lfirst(line_item))));
+                 errmsg("invalid entry for token \"%s\"",
+                        (char *) lfirst(line_item)),
+                 errdetail("In file \"%s\", line %d",
+                           HbaFileName, line_num)));    else        ereport(LOG,
(errcode(ERRCODE_CONFIG_FILE_ERROR),