Re: Proposed patch - psql wraps at window width

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, Apr 24, 2008 at 8:30 AM, Bruce Momjianwrote:
> I have moved this discussion to hackers in hopes of getting more
>  feedback, and moved the patch to a static URL:
>

Hi Bruce,

This is a very cool feature!  Looking through the patch I did have a
few thoughts.

This is definitely going to introduce merge conflicts with my
printTable API patch.  That's not a problem, just a "note to self"
that when/if this patch goes in I'll have to submit a fresh version of
my patch.

This psql message seemed a bit strange:

+         if (!quiet)
+             printf(_("Target column width for \"wrap\" format is %d.\n"),
popt->topt.columns);

To me, this message sounds like you're setting the width of a single
column, when in fact you're setting the target *total* width of the
table.  I think this message would be more clear if it read "Target
output width ..." or "Target table width ...".  Also, as far as the
user is concerned the format is referred to as  "wrapped", not "wrap".

Cheers,
BJ


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFID72J5YBsbHkuyV0RAr45AKDETJTapg6c836Cr1RS8uk3gUUH0ACdH8mQ
M8ikE3VO+3H2/rt8AvhVoew=
=Jfnk
-----END PGP SIGNATURE-----