Re: [COMMITTERS] pgsql/src/include/parser (parse_node.h parse_oper.h)
От | Thomas Lockhart |
---|---|
Тема | Re: [COMMITTERS] pgsql/src/include/parser (parse_node.h parse_oper.h) |
Дата | |
Msg-id | 37CB63EA.376BF4E5@alumni.caltech.edu обсуждение исходный текст |
Ответы |
Re: [HACKERS] Re: [COMMITTERS] pgsql/src/include/parser (parse_node.h parse_oper.h)
|
Список | pgsql-hackers |
> Modified Files: > parse_node.h parse_oper.h > Remove bogus code in oper_exact --- if it didn't find an exact > match then it tried for a self-commutative operator with the reversed input > data types. This is pretty silly; there could never be such an operator, > except maybe in binary-compatible-type scenarios, and we have oper_inexact > for that. Besides which, the oprsanity regress test would complain about > such an operator. Remove nonfunctional code and simplify routine calling > convention accordingly. Ooh! That codes sounds familiar. What I was trying for was to cover the case that, for example, (int4 < float4) was not implemented, but that (float4 >= int4) was. If this is already handled elsewhere, or if this goal is nonsensical, then cutting the defective code is the right thing. But if the code just needed repairing, we should put it back in and get it right next time... - Thomas -- Thomas Lockhart lockhart@alumni.caltech.edu South Pasadena, California
В списке pgsql-hackers по дате отправления: