Re: Index location patch for review
От | Mikheev, Vadim |
---|---|
Тема | Re: Index location patch for review |
Дата | |
Msg-id | 3705826352029646A3E91C53F7189E32016779@sectorbase2.sectorbase.com обсуждение исходный текст |
Ответ на | Index location patch for review ("Jim Buttafuoco" <jim@buttafuoco.net>) |
Список | pgsql-hackers |
> I don't understand the WAL issue below, can you explain. The dir name > is the same name as the database with _index added to it. This is how > the current datpath stuff works. I really just copied the datpath > code to get this patch to work... At the time of after crash recovery WAL is not able to read relation description from catalog and so only relfilenode is provided for storage manager in relation structure (look backend/access/transam/ xlogutils.c:XLogOpenRelation). Well, we could add Index/Table file type identifier to RmgrData (rmgr.c in the same dir) to set relkind in relation structure, but I don't see any reason to do so when we can just use different tblnode number for indices and name index dirs just like other dirs under 'base' named - ie only tblnode number is used for dir names, without any additions unrelated to storage issues. Vadim
В списке pgsql-hackers по дате отправления: