Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
| От | Daniel Gustafsson |
|---|---|
| Тема | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Дата | |
| Msg-id | 36EE762C-E3A9-4BB3-946D-EA76EDBE9ED7@yesql.se обсуждение исходный текст |
| Ответ на | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions (Fujii Masao <masao.fujii@gmail.com>) |
| Ответы |
Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
|
| Список | pgsql-hackers |
> On 17 Nov 2025, at 15:59, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Mon, Nov 17, 2025 at 11:30 PM Daniel Gustafsson <daniel@yesql.se> wrote: >> >>> On 17 Nov 2025, at 15:08, Sugamoto Shinya <shinya34892@gmail.com> wrote: >> >>> I ordered the valid encodings alphabetically and extracted those into separate parameters. >> >> LGTM. Per project style I don't think we should quote the names of encodings >> since they are visibly not English words (see commit a243569bf65c5 which deals >> with variable names, but I think it applies here as well) > > It looks like the message-style rule added in commit a243569bf65c5 > applies only to > configuration parameter names, right? And it seems that rule was later revised > by commit 17974ec2594. Is that correct? Oh right, I had forgotten about that, thanks for the reminder. The patch as proposed is correct then. -- Daniel Gustafsson
В списке pgsql-hackers по дате отправления: