Re: race condition in sync rep

Robert Haas <robertmhaas@gmail.com> writes:
>> I've added code for you.

> Your skepticism seems out of place. I actually hit this problem in testing. We could debate how realistic my test
setupwas, but why?  It is not our policy - and bad practice in general - to ship code with race conditions.  The code
youadded is not "for me"; it's "to fix a race condition".
 

In particular, in view of today's fix, shouldn't this commit be reverted?

http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6e8e7cc580665ddd43c8ca2acc6d60f345570a57

I thought at the time that that was nothing more than documenting a
known bug, and now it is documenting a dead bug.
        regards, tom lane