Re: Change pgarch_readyXlog() to return .history files first

On 12/15/18 2:10 AM, Michael Paquier wrote:
> On Fri, Dec 14, 2018 at 08:43:20AM -0500, David Steele wrote:
>> On 12/13/18 7:15 PM, Michael Paquier wrote:

>>> Or you could just use IsTLHistoryFileName here?
>>
>> We'd have to truncate .ready off the string to make that work, which
>> seems easy enough.  Is that what you were thinking?
> 
> Yes, that's the idea.  pgarch_readyXlog returns the segment name which
> should be archived, so you could just compute it after detecting a
> .ready file.
> 
>> One thing to consider is the check above is more efficient than
>> IsTLHistoryFileName() and it potentially gets run a lot.
> 
> This check misses strspn(), so any file finishing with .history would
> get eaten even if that's unlikely to happen.

Good point.  The new patch uses IsTLHistoryFileName().

>>> If one wants to simply check this code, you can just create dummy orphan
>>> files in archive_status and see in which order they get removed.
>>
>> Seems awfully racy.  Are there currently any tests like this for the
>> archiver that I can look at extending?
> 
> Sorry for the confusion, I was referring to manual testing here.

Ah, I see.  Yes, that's exactly how I tested it, in addition to doing 
real promotions.

> Thinking about it, we could have an automatic test to check for the file
> order pattern by creating dummy files, starting the server with archiver
> enabled, and then parse the logs as orphan .ready files would get
> removed in the order their archiving is attempted with one WARNING entry
> generated for each.  I am not sure if that is worth a test though.

Yes, parsing the logs was the best thing I could think of, too.

-- 
-David
david@pgmasters.net