Re: Error-safe user functions

On 2022-12-22 Th 01:10, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> And here's another for contrib/seg
>> I'm planning to commit these two in the next day or so.
> I didn't look at the jsonpath one yet.  The seg patch passes
> an eyeball check, with one minor nit: in seg_atof,
>
> +    *result = float4in_internal(value, NULL, "real", value, escontext);
>
> don't we want to use "seg" as the type_name?
>
> Even more nitpicky, in
>
> +seg_yyerror(SEG *result, struct Node *escontext, const char *message)
>  {
> +    if (SOFT_ERROR_OCCURRED(escontext))
> +        return;
>
> I'd be inclined to add some explanation, say
>
> +seg_yyerror(SEG *result, struct Node *escontext, const char *message)
>  {
> +    /* if we already reported an error, don't overwrite it */
> +    if (SOFT_ERROR_OCCURRED(escontext))
> +        return;
>
>             


Thanks for the review.


Fixed both of these and pushed.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com