Re: FETCH FIRST clause WITH TIES option

Hi,

On 11/24/18 10:28 AM, Surafel Temesgen wrote:
> Attach is rebased patch against the current master
> regards
> Surafel
> 
> On Thu, Nov 1, 2018 at 2:28 PM Surafel Temesgen <surafel3000@gmail.com
> <mailto:surafel3000@gmail.com>> wrote:
> 
>     hi,
> 
>     The attached patch include all the comment given by Tomas and i
>     check sql standard about LIMIT and this feature
> 

Unfortunately, it seems the "limit" regression tests fail for some
reason - the output mismatches the expected results for some reason. It
seems as if the WITH TIES code affects ordering of the results within
the group. See the attached file.

>     it did not say anything about it but I think its good idea to
>     include it to LIMIT too and I will add it if we have consensus on it.
> 

Hmm, I'm not sure that's needed. I don't see an urgent need to do that
in v1 of the patch.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services