Re: ci: Skip minfree file in the cores_backtrace.sh
| От | Daniel Gustafsson | 
|---|---|
| Тема | Re: ci: Skip minfree file in the cores_backtrace.sh | 
| Дата | |
| Msg-id | 343B7066-01E3-4850-B2C4-90CD84004526@yesql.se обсуждение исходный текст  | 
		
| Ответ на | Re: ci: Skip minfree file in the cores_backtrace.sh (Álvaro Herrera <alvherre@kurilemu.de>) | 
| Ответы | 
                	
            		Re: ci: Skip minfree file in the cores_backtrace.sh
            		
            		 Re: ci: Skip minfree file in the cores_backtrace.sh  | 
		
| Список | pgsql-hackers | 
> On 17 Oct 2025, at 14:25, Álvaro Herrera <alvherre@kurilemu.de> wrote: > > On 2025-Oct-17, Nazir Bilal Yavuz wrote: > >> first=1 >> -for corefile in $(find "$directory" -type f) ; do >> +# minfree is not a core file but may exists in the crash directory, skip it >> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do >> if [ "$first" -eq 1 ]; then >> first=0 >> else > > This looks quite random. Why not do "find ... -name '*core*'" instead? > I mean, if we have minfree there today, we could have maxbusy tomorrow > or whatever. I think we should be able to count of the core directory on controlled CI instances not being cluttered with random files - if it is we probably want a test failure logged so we can look at it - but minfree is a special file for core dump handling on some platforms so skipping that make sense I think. -- Daniel Gustafsson
В списке pgsql-hackers по дате отправления: