Re: fix typos
От | Tom Lane |
---|---|
Тема | Re: fix typos |
Дата | |
Msg-id | 3437166.1659620465@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: fix typos (John Naylor <john.naylor@enterprisedb.com>) |
Ответы |
Re: fix typos
|
Список | pgsql-hackers |
John Naylor <john.naylor@enterprisedb.com> writes: > On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby <pryzby@telsasoft.com> wrote: > ereport(ERROR, > (errcode(ERRCODE_OBJECT_IN_USE), > - errmsg("could not drop replication origin with OID %d, in use by PID %d", > + errmsg("could not drop replication origin with OID %u, in use by PID %d", > RepOriginId is a typedef for uint16, so this can't print the wrong answer, > but it is inconsistent with other uses. So it seems we don't need to > backpatch this one? Um ... if it's int16, then it can't be an OID, so I'd say this message has far worse problems than %d vs %u. It should not use that terminology. regards, tom lane
В списке pgsql-hackers по дате отправления: