Re: ATSimpleRecursion() and inheritance foreign parents

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: ATSimpleRecursion() and inheritance foreign parents
Дата
Msg-id 34270.1430249755@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: ATSimpleRecursion() and inheritance foreign parents  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Ответы Re: ATSimpleRecursion() and inheritance foreign parents  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Список pgsql-hackers
Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> writes:
> On 2015/04/28 15:17, Amit Langote wrote:
>> The code at the beginning of ATSimpleRecursion() looks like -
>> if (recurse && rel->rd_rel->relkind == RELKIND_RELATION)
>> Not sure if it's great idea, but now that foreign tables can also have
>> children, should above be changed to take that into account?

> Yeah, I think we should now allow the recursion for inheritance parents 
> that are foreign tables as well.  Attached is a patch for that.

Yeah, this is just an oversight.  Fix pushed, and also a similar fix in
parse_utilcmd.c.  I thought I'd reviewed all the references to
RELKIND_RELATION before, but evidently I missed these.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: COPY and file_fdw with fixed column widths
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: INSERT ... ON CONFLICT syntax issues