Hi Andres.
On 2018/03/02 13:34, Andres Freund wrote:
> - reorganize partitioning code
>
> NR. Created recently, but split off an older patch.
>
> Seems like a generally reasonable idea. Wonder if it conflicts with
> some other partition related patches?
It actually does. There are at least a few other functionality patches
that touch same files and it may not be a good idea for them to have to
worry about conflicts with this.
I gave up on rebasing this patch yesterday as I couldn't finish it in 5
minutes, but maybe I will try later this month. Gotta focus on the faster
pruning stuff for now...
> - Add support for tuple routing to foreign partitions
>
> NR. Patch is still evolving, the latest versions haven't gotten a lot
> of review.
>
> It seems a bit ambitious to try to get this into v11.
I've looked at this a bit yesterday and plan to do review it sometime this
month. Having skimmed it, the new FDW API added by the patch looks well
documented and seems to do the very specific job assigned to it well
enough, but then again I haven't done a full review yet.
Thanks,
Amit