Re: Extensible Rmgr for Table AMs

Jeff Davis <pgsql@j-davis.com> writes:
> I'm happy with this patch and I committed it.

wrasse is less happy:

ccache /opt/developerstudio12.6/bin/cc  -m64 -Xa -v -O  findtimezone.o initdb.o localtime.o -L../../../src/port
-L../../../src/common-L../../../src/fe_utils -lpgfeutils -L../../../src/common -lpgcommon -L../../../src/port -lpgport
-L../../../src/interfaces/libpq-lpq   -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/openldap-64/lib
-Wl,--as-needed-Wl,-R'/home/nm/farm/studio64v12_6/HEAD/inst/lib'  -lpgcommon -lpgport -lxslt -lxml2 -lpam -lssl
-lcrypto-lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -lm  -o initdb 
Undefined            first referenced
 symbol                  in file
RmgrTable                           initdb.o
ld: fatal: symbol referencing errors

I think this means the static inline functions you added in
xlog_internal.h need to be wrapped in #ifndef FRONTEND.

            regards, tom lane