Re: [PATCH] Largeobject access controls

2009/9/24 KaiGai Kohei <kaigai@ak.jp.nec.com>:
> The attached patch is revised from the previous revision at the following points:
>
> - The "largeobject_compat_acl" is renamed to "largeobject_check_acl".
>  Its default is on, and turning it off means the largeobject stuff
>  performs in compatible mode for the v8.4.x or prior releases.
> - Notification messages were eliminated at the compatible mode.
>  It always allows to bypass ACL checks without any warnings.
>

a few minor points:

+         For example, the <literal>lo_import()</literal> and
+         <literal>lo_export</literal> need superuser privileges independent
+         from this setting, as if the prior version doing.

that should read "as prior versions were doing"?

and you're still using pg_largeobject_meta in some comments in
src/include/catalog/pg_largeobject_metadata.h

besides that it looks good to me...
i will mark the patch as "ready for committer"

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157