Re: ECPG dynamic cursor, SQLDA support

On Wed, Jun 24, 2009 at 4:51 AM, Boszormenyi Zoltan<zb@cybertec.at> wrote:
> Hi,
>
> attached is our latest patch extending ECPG:
>

haven't tested this nor reviewed the code in detail, just some little questions:

1) This is in /src/interfaces/ecpg/ecpglib/sqlda.c, and doesn't seems
something we want in our files... looking at actual code seems like
ecpg.c have something similar but at least specify that it has the
same license as PostgreSQL

+  *
+  * (C) 2009 Cybertec GmbH
+  *     Zoltán Böszörményi <zb@cybertec.at>
+  *     Hans-Jürgen Schönig <hs@cybertec.at>
+  */

2) In src/interfaces/ecpg/include/sqltypes.h there some #if 0 added,
why are those? seems like something that doesn't need to be added

+ #if 0
+ #define   SQLSET      19
+ #define   SQLMULTISET 20
+ #define   SQLLIST     21
+ #define   SQLROW      22
+ #define   SQLCOLLECTION   23
+ #define   SQLROWREF   24
+ #endif

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157