Re: Merge Append Patch merged up to 85devel

On Sun, Jul 5, 2009 at 7:23 PM, Greg Stark<stark@mit.edu> wrote:
>>>
>>> Here's a copy of the merge-append patch that I sent months ago merged up to
>>> head. I haven't really added any additional functionality since then.
>>
>> Can you provide some more details about the objective of this patch?  Or a
>> link to previous discussion?
>

i was trying to test this one but i can't find a query that produces a
diferent plan than in 8.4.0, attached my current test just in case...
what kind of query is this intended to help?

something, maybe style dependant, that i don't like is the definition
of  LAPPEND_PATH_FLATTEN_APPENDPATHS macro at some point in the middle
of the file i prefer they be defined at the top (just my
preference)... or there is a reason for doing it there?

another thing a don't like is those #ifdef FIXME surrounding already
existing if, why are those? and if they need to be fixed why there
isn't a comment explaining what the fix is or what it should behave?

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157