Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Дата
Msg-id 3041648.1660915699@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Fix typo with logical connector (src/backend/commands/vacuumparallel.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Список pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes:
> At function parallel_vacuum_process_all_indexes there is
> a typo with a logical connector.
> I think that correct is &&, because both of the operators are
> bool types [1].
> As a result, parallel vacuum workers can be incorrectly enabled.

Since they're bools, the C spec requires them to promote to integer
0 or 1, therefore the & operator will yield the desired result.
So there's not going to be any incorrect behavior.  Nonetheless,
I agree that && would be better, because it would short-circuit
the evaluation of parallel_vacuum_index_is_parallel_safe() when
there's no need.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Geier
Дата:
Сообщение: Re: Reducing planning time on tables with many indexes
Следующее
От: Justin Pryzby
Дата:
Сообщение: Re: MERGE and parsing with prepared statements