Re: doc: modify the comment in function libpqrcv_check_conninfo()

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: doc: modify the comment in function libpqrcv_check_conninfo()
Дата
Msg-id 2faf37e9-3941-43b5-93e8-f54965b250df@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: doc: modify the comment in function libpqrcv_check_conninfo()  (ikedarintarof <ikedarintarof@oss.nttdata.com>)
Ответы Re: doc: modify the comment in function libpqrcv_check_conninfo()
Список pgsql-hackers

On 2024/07/08 20:44, ikedarintarof wrote:
> I remove the unclear part from the previous patch and add some explanation for
>   later part of the function.

- * Validate connection info string, and determine whether it might cause
- * local filesystem access to be attempted.
+ * The function
+ * 1. validates connection info string and
+ * 2. checks a password is provided if must_use_password is true.

IMO, "Validate connection info string" is sufficient. The mention of
must_use_password is redundant since it's explained in the latter part of
the comment. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



В списке pgsql-hackers по дате отправления: