Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

On 2021/01/26 12:08, Bharath Rupireddy wrote:
> On Tue, Jan 26, 2021 at 12:38 AM Fujii Masao
> <masao.fujii@oss.nttdata.com> wrote:
>>> Attaching v17 patch set, please review it further.
>>
>> Thanks for updating the patch!
>>
>> Attached is the tweaked version of the patch. I didn't change any logic,
>> but I updated some comments and docs. Also I added the regresssion test
>> to check that postgres_fdw_disconnect() closes multiple connections.
>> Barring any objection, I will commit this version.
> 
> Thanks. The patch LGTM, except few typos:
> 1) in the commit message "a warning messsage is emitted." it's
> "message" not "messsage".
> 2) in the documentation "+   a user mapping, the correspoinding
> connections are closed." it's "corresponding" not "correspoinding".

Thanks for the review! I fixed them and pushed the patch!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION