Re: page macros cleanup

On Fri, Jul 4, 2008 at 1:01 PM, Zdenek Kotala <Zdenek.Kotala@sun.com> wrote:
>
>
> Good catch. I lost in basic arithmetic. What I see now that original
> definition count sizeof(ItemIdData) twice and on other side it does not take
> care about MAXALING correctly. I think correct formula is:
>
> #define HashMaxItemSize(page) \
>        (PageGetPageSize(page) - \
>          ( MAXALIGN(SizeOfPageHeaderData + sizeof(ItemIdData))+ \
>            MAXALIGN(sizeof(HashPageOpaqueData)) \
>          )\
>         )
>
> What do you think?
>


Yes. I think that's the correct way.


Thanks,
Pavan

--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com