Re: 8.3.0 Core with concurrent vacuum fulls

On Thu, Mar 6, 2008 at 11:30 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
>  I think that just makes things more complex and fragile.  I like
>  Heikki's idea, in part because it makes the normal path and the WAL
>  recovery path guaranteed to work alike.  I'll attach my work-in-progress
>  patch for this --- it doesn't do anything about the invalidation
>  semantics problem but it does fix the critical-section-too-big problem.
>

The WIP patch looks good to me. I haven't yet tested it (will wait for the
final version). The following pointer arithmetic caught my eye though.

!   nunused = (end - nowunused);

Shouldn't we typecast them to (char *) first ?

Thanks,
Pavan

-- 
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com