On 16.12.25 23:03, Corey Huinker wrote:
> I've been looking at ways to reorganize and/or clean up pg_dump.c.
>
> One thing I have noticed is the usage of PQExpBuffer in situations where
> the query has no optional parts and no string interpolation.
>
> Attached is a patch to replace those usages with the string literal
> itself.
I'm not sure this is better. It seems better to me to use consistent
APIs throughout. Kind of like using printf even if you don't need to
substitute anything, rather than using a mix of printf and puts.