Re: automating perl compile time checking

> On 5 Jun 2018, at 16:31, Andrew Dunstan <andrew.dunstan@2ndquadrant.com> wrote:

> The patch contains a simple script to run the checks. The code that finds perl files is put in a function in a single
filethat is sourced by the three locations that need it. 

+1 on centralizing the find-files function.

> The directory pgperlcritic is renamed to perlcheck, as it not contains the new script as well as pgperlcritic.

This comment should say “perlcheck/..” and not “pgperlcritic/.." I assume:

--- /dev/null
+++ b/src/tools/perlcheck/pgperlcritic
@@ -0,0 +1,20 @@
+#!/bin/sh
+
+# src/tools/pgperlcritic/pgperlcritic

cheers ./daniel