Re: Fix runtime errors from -fsanitize=undefined

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-07-05 01:33, Noah Misch wrote:
>> I just saw this proposal.  The undefined behavior in question is strictly
>> academic.  These changes do remove the need for new users to discover
>> -fno-sanitize=nonnull-attribute, but they make the code longer and no clearer.
>> Given the variety of code this touches, I expect future commits will
>> reintroduce the complained-of usage patterns, prompting yet more commits to
>> restore the invariant achieved here.  Hence, I'm -0 for this change.

> This sanitizer has found real problems in the past.  By removing these
> trivial issues we can then set up a build farm animal or similar to
> automatically check for any new issues.

I think Noah's point is just that we can do that with the addition of
-fno-sanitize=nonnull-attribute.  I agree with him that it's very
unclear why we should bother to make the code clean against that
specific subset of warnings.

            regards, tom lane