Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
От | Tom Lane |
---|---|
Тема | Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value |
Дата | |
Msg-id | 291749.1674171832@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value (sirisha chamarthi <sirichamarthi22@gmail.com>) |
Ответы |
Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
|
Список | pgsql-hackers |
sirisha chamarthi <sirichamarthi22@gmail.com> writes: > On Wed, Oct 19, 2022 at 7:59 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com> > wrote: >> In short, the proposed fix alone seems fine to me. If we want to show >> further details, I would add a bit as follows. >> >> | * * WALAVAIL_REMOVED means it has been removed. A replication stream on >> | * a slot with this LSN cannot continue. Note that the affected >> | * processes have been terminated by checkpointer, too. > Thanks for your comments! Attached the patch with your suggestions. Pushed with a bit of additional wordsmithing. I thought "have been" was a bit too strong of an assertion considering that this function does not pay any attention to the actual state of any processes, so I made it say "should have been". regards, tom lane
В списке pgsql-hackers по дате отправления: