Re: Use INT_MAX for wal size related gucs's max value

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Use INT_MAX for wal size related gucs's max value
Дата
Msg-id 2881720.1681875236@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Use INT_MAX for wal size related gucs's max value  (Junwang Zhao <zhjwpku@gmail.com>)
Ответы Re: Use INT_MAX for wal size related gucs's max value  (Junwang Zhao <zhjwpku@gmail.com>)
Список pgsql-hackers
Junwang Zhao <zhjwpku@gmail.com> writes:
> The wal size related gucs use the MB unit, so we should just use
> INT_MAX instead of MAX_KILOBYTES as the max value.

The point of MAX_KILOBYTES is to avoid overflow when the value
is multiplied by 1kB.  It does seem like that might not be
appropriate for these values, but that doesn't mean that we can
blithely go to INT_MAX.  Have you chased down how they are used?

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Junwang Zhao
Дата:
Сообщение: Use INT_MAX for wal size related gucs's max value
Следующее
От: Junwang Zhao
Дата:
Сообщение: Re: Use INT_MAX for wal size related gucs's max value