Re: Alpha test
От | Tom Lane |
---|---|
Тема | Re: Alpha test |
Дата | |
Msg-id | 28692.1072138423@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Alpha test (Alvaro Herrera <alvherre@dcc.uchile.cl>) |
Ответы |
Re: Alpha test
Re: Alpha test |
Список | pgsql-patches |
Alvaro Herrera <alvherre@dcc.uchile.cl> writes: > On Mon, Dec 22, 2003 at 06:36:32PM -0500, Bruce Momjian wrote: >> Seems we have to test for __alpha and __alpha_. This applied patch >> makes that consistent. > Won't something like the following work? > #ifdef(__alpha) > #define __alpha__ 1 > #endif It seems risky to me to define macros that are in the reserved-for-system-use namespace. Who knows what might break in the system headers if we did that? I'm not convinced that all of the changes Bruce made are needed, or even not likely to break things themselves. What if __alpha and __alpha__ actually indicate slightly different platforms or OS releases? For example, we have *no* evidence to suggest that that NOFIXADE stuff in main.c is needed on platforms that don't define __alpha. I would tend to take an "if it ain't broke don't fix it" approach, especially on platforms we don't have handy to test. regards, tom lane
В списке pgsql-patches по дате отправления: