Re: quiet inline configure check misses a step for clang

Andres Freund <andres@2ndquadrant.com> writes:
> There's another problematic case:
> http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=olinguito&dt=2014-05-01%2021%3A22%3A43&stg=config

> /usr/local/lib/libxml2.so.14.0: warning: strcpy() is almost always misused, please use strlcpy()
> /usr/local/lib/libxml2.so.14.0: warning: strcat() is almost always misused, please use strlcat()
> /usr/local/lib/libxslt.so.3.8: warning: sprintf() is often misused, please use snprintf()

> That's not new. And it seems like a case of really misguided platform
> specific changes (actually smelling a bit of zealotry). So I'd be
> prepared to ignore it. Other opinions?

Yeah, I've noticed those before, and concluded that "misguided zealotry"
is the appropriate classification.  I certainly won't do anything about
those.  (These particular ones, we *can't* do anything about, since the
calls are inside libraries we don't control the source of...)

> How on earth could it be a good idea to warn about this when linking to
> libraries instead of warning when a function is actually used during
> compilation?

Not only misguided, but crappily implemented zealotry.
        regards, tom lane