Re: create type error message

"Jim Buttafuoco" <jim@contactbda.com> writes:
> # create type a as (a text,b int);
> CREATE TYPE
> # create type a as (a text,b int);
> ERROR:  relation "a" already exists

> seems like  
> ERROR: type "a" already exists
> would be better.

It's not really all that easy, because tables and composite types both
have entries in both pg_class and pg_type.  Consider

regression=# create table tt (a text,b int);
CREATE TABLE
regression=# create type tt as (a text,b int);
ERROR:  relation "tt" already exists

regression=# create type zz as (a text,b int);
CREATE TYPE
regression=# create table zz (a text,b int);
ERROR:  relation "zz" already exists

In all three cases the error is actually detected inside
heap_create_with_catalog, because we choose to make the pg_class entry
first.  We could possibly alter the error report based on the relkind
of the entry we are about to make, but I'm unconvinced it'd be an
improvement...
        regards, tom lane