Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

On 7/29/21 8:29 PM, Michael Paquier wrote:
> On Thu, Jul 29, 2021 at 01:26:22PM -0400, Andrew Dunstan wrote:
>> It gets stuck in a loop like this:
>>
>> ok 19 - one partial WAL segment was created
>> 0/2001968
>> # Running: pg_receivewal -D
H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_basebackup/tmp_check/t_020_pg_receivewal_primary_data/archive_wal--verbose
--endpos0/3000028 --compress 1 
 
>> pg_receivewal: starting log streaming at 0/2000000 (timeline 1)
>> pg_receivewal: error: could not write 131072 bytes to WAL file "000000010000000000000002": Permission denied
>> pg_receivewal: error: could not close file "000000010000000000000002": Permission denied
>> pg_receivewal: disconnected; waiting 5 seconds to try again
> Hmm.  This error is strange.  Still, it is an oversight of ffc9ddae to
> not use --no-loop here for the two new commands of pg_receivewal
> --endpos.  Please see the attached.



Well that unsticks the test, so now it fails in an ordinary way, so +1
for doing that. I must say that --no-loop seems a little ill-designed.
Effectively we have to choose between zero loops and infinite loops. 
But that seems to be a matter of ancient (or at least medieval) history.


I will see if a more modern zlib helps matters.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com