Re: pgsql: Fix bug leading to restoring unlogged relations from empty files

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Fix bug leading to restoring unlogged relations from empty files
Дата
Msg-id 27390.1450028238@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Fix bug leading to restoring unlogged relations from empty files  (Andres Freund <andres@anarazel.de>)
Ответы Re: pgsql: Fix bug leading to restoring unlogged relations from empty files  (Andres Freund <andres@anarazel.de>)
Список pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> Fix bug leading to restoring unlogged relations from empty files.

Coverity thinks, quite correctly AFAICS, that this line you wrote in
FlushOneBuffer() is useless:

    LWLockHeldByMe(bufHdr->content_lock);

Perhaps you meant

    Assert(LWLockHeldByMe(bufHdr->content_lock));

?

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: pgsql: Properly initialize write, flush and replay locations in walsend
Следующее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Fix bug leading to restoring unlogged relations from empty files