Re: Pgoutput not capturing the generated columns
От | Tom Lane |
---|---|
Тема | Re: Pgoutput not capturing the generated columns |
Дата | |
Msg-id | 273755.1737688147@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Pgoutput not capturing the generated columns (Amit Kapila <amit.kapila16@gmail.com>) |
Ответы |
Re: Pgoutput not capturing the generated columns
|
Список | pgsql-hackers |
Amit Kapila <amit.kapila16@gmail.com> writes: > On Fri, Jan 24, 2025 at 4:41 AM Peter Smith <smithpb2250@gmail.com> wrote: >> However, in hindsight, I am not sure that the column should have been >> renamed 'pubgencols_type' in the first place because I cannot find any >> other catalogs with an underscore in their column names. > See pg_rewrite.ev_type for a similar case. I think the problem is not so much the underscore as the inconsistency. You've got "pub", "gen", and "cols" run together, but then you feel a need to separate "type"? It just looks wrong, the more so because no other column in that catalog has an underscore in its name. I see that this was carried over from a related C typedef name, but users aren't going to see that. They'll just see that somebody couldn't be bothered to maintain a consistent style. regards, tom lane
В списке pgsql-hackers по дате отправления: