Re: PL/Python warnings in CVS HEAD

Neil Conway <neilc@samurai.com> writes:
>> No, it just looks like a Python API 2.5 change to me

> Attached is a patch that fixes the warnings. Unfortunately, it seems
> this patch won't compile against Python 2.4: the 2.5 API requires the
> use of some typedef's that AFAICS were only introduced in 2.5.

> Since we presumably still want to support Python < 2.5, we can either
> not apply this patch and tolerate the warnings, or else we can
> workaround the incompatibility with some preprecessor hackery (e.g.
> supply the missing typedef's ourselves if Python doesn't provide them).

Sounds like #ifdef time to me --- but it seems a bit strange; wouldn't
the Python guys have taken a bit more care for compatibility of
user-supplied code?  We're hardly the only people who want to support
multiple Python versions.  Perhaps they provide a compatibility hack
that you didn't spot?
        regards, tom lane