Re: pgsql: Further code review for pg_lsn data type.

Andres Freund <andres@2ndquadrant.com> writes:
> 6.3.1.3 Signed and unsigned integers, paragraph 3:
> "Otherwise, the new type is signed and the value cannot be represented
> in it; either the result is implementation-defined or an
> implementation-defined signal is raised."

"Implementation-defined" is entirely different from "undefined".
In practice, every two's-complement machine in the world is going
to define this behavior the same way.  The standard is written the
way it is to avoid assuming that the underlying hardware is
two's-complement ... but there are no such machines outside museums.

I think you're making a problem out of nothing.  We have considerably
more-real portability issues to worry about, like memory ordering.

            regards, tom lane