Re: pgsql: Expand AclMode to 64 bits

On 2022-11-25 Fr 01:52, Amit Langote wrote:
> Hi Andrew,
>
> On Thu, Nov 24, 2022 at 10:18 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> On 2022-11-23 We 19:40, Michael Paquier wrote:
>>> Hi Andrew,
>>>
>>> On Wed, Nov 23, 2022 at 07:44:04PM +0000, Andrew Dunstan wrote:
>>>> Expand AclMode to 64 bits
>>>>
>>>> We're running out of bits for new permissions. This change doubles the
>>>> number of permissions we can accomodate from 16 to 32, so the
>>>> forthcoming new ones for vacuum/analyze don't exhaust the pool.
>>>>
>>>> Nathan Bossart
>>>>
>>>> Reviewed by: Bharath Rupireddy, Kyotaro Horiguchi, Stephen Frost, Robert
>>>> Haas, Mark Dilger, Tom Lane, Corey Huinker, David G. Johnston, Michael
>>>> Paquier.
>>> crake is complaining for the upgrades from v12:
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-11-23%2023%3A32%3A04
>>>
>>> It seems that there are some tables dependent on aclitem, bumping on
>>> your incompatible change.
>> Yeah, testing a fix for it, thanks.
> Not sure if it is related to the above, but I noticed a problem when
> rebasing my patch that moves requiredPerms out of RangeTblEntry.  I
> think the commit may have missed doing the following (diff attached):



pushed, thanks.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com