Re: Patch: show relation and tuple infos of a lock to acquire

Simon Riggs <simon@2ndQuadrant.com> writes:
> On 31 December 2013 09:12, Christian Kruse <christian@2ndquadrant.com> wrote:
>> Output with patch:
>> 
>> LOG:  process 24774 acquired ShareLock on transaction 696 after 11688.720 ms
>> CONTEXT:  relation name: foo (OID 16385)
>> tuple (ctid (0,1)): (1)

> That is useful info.

> I think the message should be changed to say this only, without a context line

> LOG:  process 24774 acquired ShareLock on relation "foo" (OID 16385)
> tuple (0,1) after 11688.720 ms

> My reason is that pid 24774 was waiting for a *tuple lock* and it was
> eventually granted, so thats what it should say.

No, that wasn't what it was waiting for, and lying to the user like that
isn't going to make things better.

Christian's idea of a context line seems plausible to me.  I don't
care for this implementation too much --- a global variable?  Ick.
Make a wrapper function for XactLockTableWait instead, please.
And I'm not real sure that showing the whole tuple contents is a good
thing; I can see people calling that a security leak, not to mention
that the performance consequences could be dire.
        regards, tom lane