Re: What is HeapScanDescData.rs_initblock good for?

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> The BRIN patch added a HeapScanDescData field rs_initblock, but so far as
>> I can see it's utterly without use, and it's quite confusing (people might
>> mistake it for rs_startblock, for example).  Any objection to taking it
>> out again?

> Ouch, you're right, my mistake.  Feel free to remove it, yeah.

... While I'm looking at it, it sure looks like the BRIN patch broke
syncscan for those index build methods that were using it, which was
most.  You've got IndexBuildHeapRangeScan unconditionally calling
heap_setscanlimits and thereby trashing the result of ss_get_location().

I'm inclined to let it call heap_setscanlimits only if not allow_sync.
        regards, tom lane