Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that
От | Tom Lane |
---|---|
Тема | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that |
Дата | |
Msg-id | 23879.1533662232@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that (Jacob Champion <pchampion@pivotal.io>) |
Ответы |
Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that
|
Список | pgsql-hackers |
Jacob Champion <pchampion@pivotal.io> writes: > On Mon, Aug 6, 2018 at 12:45 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Ah, gotcha. But whether the behavior is sane or not, it'd be reproducible >> for any specific input dataset on any specific platform (unless you've got >> a quicksort that actually uses randomized pivots; but ours doesn't, and >> I think that pg_dump does use src/port/qsort.c). So that partially >> answers Andrew's question as to why we've not seen instability in the >> buildfarm's results. > I completely missed that the qsort in use was part of libpgport; that > should make it much easier to repro. We'll give it a shot. I don't see any reason to insist on a test case before pushing this fix, so I did that. (As I expected, the fix doesn't change any existing regression test results.) regards, tom lane
В списке pgsql-hackers по дате отправления: