Re: Problem with dblink

Joe Conway <mail@joeconway.com> writes:
> Attached fixes a recently reported bug in dblink. If there are no
> objections, I'll make this my first commit :-)

Looks right to me; but as a general tip, if you've made mistake X in
place A, you might have made it in place B too.  Have you checked the
rest of dblink for forgotten SPI_finish calls?

(More generally, I wonder if AtEOXact_SPI oughtn't be fixed to emit
a WARNING if the SPI stack isn't empty, except in the error case.
Neglecting SPI_finish is analogous to a resource leak, and we have
code in place to warn about other sorts of leaks.)

> I intend to apply it to HEAD and REL7_4_STABLE, but it could also be
> applied to REL7_3_STABLE -- any opinions on that? Are we still
> considering a 7.3.5 release?

Sure.  I believe we still intend a 7.3.5 shortly (maybe early December,
since Thanksgiving week is a bad time to expect anything to happen).

            regards, tom lane