Re: make "wal_debug" GUC var a boolean

Neil Conway <neilc@samurai.com> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> The others are already #ifdef'd out by default, which is more or
>> less what I was suggesting you do with the wal_debug code.

> (FWIW, trace_notify is not #ifdef'd out.)

My mistake --- if you feel like making it so, go to it.

> But I thought that you (and Peter) were suggesting that this shouldn't
> be made a GUC variable at all, just a preprocessor definition.

I think the combination of #ifdef and GUC variable is appropriate.
Just because you want to debug something doesn't necessarily mean you
want the log messages on full strength every instant, especially for
high-volume messages such as the WAL ones.  You might for instance want
to log just one backend's WAL activity.

            regards, tom lane