Michael Paquier <michael@paquier.xyz> writes:
> Still, the current style is not a pattern I think we should spread
> around, as a lot of copy-paste gets done in new tests added and one
> would easily mix up queries with pattern checks. The practice I'd
> like to encourage is something like the attached, to make clear that
> there is no risk to fetch incorrect logs.
If you prefer. However, I'd note that this patch as it stands
sort of breaks the argument I just made, as now you are interrogating
the postmaster's state after sending SIGHUP and before doing anything
that will wait for that to take effect. I think you should move the
location-capture commands down by at least one safe_psql call.
regards, tom lane