Re: Fdw batch insert error out when set batch_size > 65535
| От | Tom Lane |
|---|---|
| Тема | Re: Fdw batch insert error out when set batch_size > 65535 |
| Дата | |
| Msg-id | 2131017.1623451468@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: Fdw batch insert error out when set batch_size > 65535 (Tomas Vondra <tomas.vondra@enterprisedb.com>) |
| Ответы |
Re: Fdw batch insert error out when set batch_size > 65535
|
| Список | pgsql-hackers |
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> There's one caveat, though - for regular builds the slowdown is pretty
> much eliminated. But with valgrind it's still considerably slower. For
> postgres_fdw the "make check" used to take ~5 minutes for me, now it
> takes >1h. And yes, this is entirely due to the new test case which is
> generating / inserting 70k rows. So maybe the test case is not worth it
> after all, and we should get rid of it.
I bet the CLOBBER_CACHE animals won't like it much either.
I suggest what we do is leave it in place for long enough to get
a round of reports from those slow animals, and then (assuming
those reports are positive) drop the test.
regards, tom lane
В списке pgsql-hackers по дате отправления: